Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cfile root and file blocks dynamic #3872

Merged
merged 3 commits into from Jan 8, 2022

Conversation

notimaginative
Copy link
Contributor

Remove limit on number of roots and files supported by cfilesystem.

@notimaginative
Copy link
Contributor Author

Works on my limited data set but needs further testing with very large numbers of roots/files.

@wookieejedi wookieejedi added the enhancement A new feature or upgrade of an existing feature to add additional functionality. label Dec 30, 2021
code/cfile/cfilesystem.cpp Outdated Show resolved Hide resolved
@EatThePath
Copy link
Contributor

Works on my limited data set but needs further testing with very large numbers of roots/files.

@notimaginative how large is usefully large for testing?

@notimaginative
Copy link
Contributor Author

Preferably above 70k, which puts it over the old limit. But anything over 50k would probably be a good enough high mark to verify everything works.

@notimaginative notimaginative marked this pull request as ready for review January 3, 2022 23:26
@notimaginative
Copy link
Contributor Author

Tested with over 100k files without issue so this should be as ready as it's going to get.

@Goober5000 Goober5000 merged commit 59442ef into scp-fs2open:master Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or upgrade of an existing feature to add additional functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants