New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add a Halloween fact #226

Open
scrabill opened this Issue Oct 28, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@scrabill
Owner

scrabill commented Oct 28, 2018

@brandonstinson added a list of random Halloween facts that generate on page load.

The facts (strings) are stored in a facts array. Adding a new item to this array is an easy, first-timer-friendly pull request.

  • Within script.js, look for the comment // Array of Halloween facts.
  • Add a new fact to the facts array (try to keep them 1-2 lines long)
  • Open a pull request with your new fact(s) and I'll get them added in.

Reach out if you have any questions.

Edit: Wow, there's been an explosion of pull requests relating to this template in the past 12 hours! To keep this array and JS file from getting out of hand, please limit your facts to no more than 3 lines total.

@shoutoutloud

This comment has been minimized.

Contributor

shoutoutloud commented Oct 28, 2018

Hi, can I help with this issue.

@feralpoosum feralpoosum referenced this issue Oct 28, 2018

Merged

Added a few more facts #235

1 of 4 tasks complete

@honey2156 honey2156 referenced this issue Oct 28, 2018

Merged

Added random halloween facts #241

1 of 4 tasks complete

@arminkhoshbin arminkhoshbin referenced this issue Oct 28, 2018

Merged

added a few more halloween facts :tada: #242

1 of 4 tasks complete

@stefanivic stefanivic referenced this issue Oct 28, 2018

Merged

Adds a new Halloween fact #243

1 of 4 tasks complete

@johannroth johannroth referenced this issue Oct 28, 2018

Merged

adds a halloween fact #247

1 of 4 tasks complete

@bblarney bblarney referenced this issue Oct 28, 2018

Merged

added new halloween fact #256

1 of 4 tasks complete

@Scriptle Scriptle referenced this issue Oct 28, 2018

Merged

Added a fact. #255

1 of 4 tasks complete

@BitBoy92 BitBoy92 referenced this issue Oct 28, 2018

Merged

Pumpkin halloween fact #262

1 of 4 tasks complete

CristinaRuth referenced this issue in CristinaRuth/how-many-days-until-halloween Oct 29, 2018

scrabill added a commit that referenced this issue Oct 29, 2018

Merge pull request #265 from CristinaRuth/master
Issue #226 - add a halloween fact

@music-mind music-mind referenced this issue Oct 29, 2018

Merged

Added Halloween Facts! #270

1 of 4 tasks complete

@VinayakBagaria VinayakBagaria referenced this issue Oct 29, 2018

Merged

Added new fact - economic point #274

1 of 4 tasks complete

@christophszcz christophszcz referenced this issue Oct 30, 2018

Merged

Add a new halloween fact. #287

1 of 4 tasks complete

@MarcusRobinson928 MarcusRobinson928 referenced this issue Nov 15, 2018

Open

Added 3 new facts. #312

1 of 4 tasks complete
@chansen17

This comment has been minimized.

chansen17 commented Nov 19, 2018

Super old! But is it still cool to add a Holloween fact!? For practice sake, thanks. D;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment