Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add a random costume idea generator #202
How Many Days Until Halloween? Pull Request
Add a random costume idea generator.
Type of Change was Made?
What type of change does your code introduce? After creating the PR, tick the checkboxes that apply.
Description of the Change Being Made.
A button and text were added to the page. When a user clicks on the
Changes were made to:
FYI see line 31 of script.js: spooky.innerText was changed to spooky.HTML in order to allow for HTML elements.
Re: PR #201
Potential Performance Issues
Styles were added in styles.css using CSS Flexbox and a media query. I'm not 100% sure if this will have an impact on original styling associated with Bootstrap but it looks fine to me so far.
Checked the new feature in Firefox, Safari and Chrome (all desktop) and with Firefox and Chrome dev tools device simulators. The feature has not been checked in actual mobile browsers - I'm not sure how to do that.