New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a random costume idea generator #202

Merged
merged 7 commits into from Oct 28, 2018

Conversation

Projects
None yet
2 participants
@stufinn
Contributor

stufinn commented Oct 9, 2018

How Many Days Until Halloween? Pull Request

Descriptive name.

Add a random costume idea generator.

Type of Change was Made?

What type of change does your code introduce? After creating the PR, tick the checkboxes that apply.

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Description of the Change Being Made.

A button and text were added to the page. When a user clicks on the pumpkin bat-shaped button, a random costume idea and associated link appear.

Changes were made to:

  • css/styles.css
  • js/script.js

FYI see line 31 of script.js: spooky.innerText was changed to spooky.HTML in order to allow for HTML elements.

Issue Number

Re: PR #201

Potential Performance Issues

Styles were added in styles.css using CSS Flexbox and a media query. I'm not 100% sure if this will have an impact on original styling associated with Bootstrap but it looks fine to me so far.

Tests/Checks

Checked the new feature in Firefox, Safari and Chrome (all desktop) and with Firefox and Chrome dev tools device simulators. The feature has not been checked in actual mobile browsers - I'm not sure how to do that.

New Dependencies

n/a

@scrabill scrabill merged commit ccabb60 into scrabill:master Oct 28, 2018

@scrabill scrabill removed the working on it label Oct 28, 2018

@scrabill

This comment has been minimized.

Owner

scrabill commented Oct 28, 2018

@stufinn

I just added this! It works but it looks like the bat image (or icon/emoji) got lost in the shuffle.

Can you add it as a new PR so that I can add it in?

@stufinn

This comment has been minimized.

Contributor

stufinn commented Oct 28, 2018

thanks for merging that! I can definitely do that if not tonight, then tomorrow for sure.

@stufinn

This comment has been minimized.

Contributor

stufinn commented Oct 28, 2018

@scrabill From my end the bat emoji is showing up both locally and on the live site. I'm viewing on a mac (Chrome, Firefox & Safari all look OK). It's still not showing up for you?

@stufinn stufinn deleted the stufinn:randomCostumeButton branch Oct 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment