{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":564090825,"defaultBranch":"master","name":"pytorch","ownerLogin":"scramsby","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-11-10T01:03:27.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/20998199?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1683180059.0","currentOid":""},"activityList":{"items":[{"before":"efad5fdb3d972f5ce76b34aa4948169066a872f2","after":"4a043ed01297c959bc2d853a333059152b7b7167","ref":"refs/heads/export-D45463620","pushedAt":"2023-05-05T17:15:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"scramsby","name":"Scott Ramsby","path":"/scramsby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20998199?s=80&v=4"},"commit":{"message":"[fbcode/caffe2] Make fmt formatter methods const (#100616)\n\nSummary:\nPull Request resolved: https://github.com/pytorch/pytorch/pull/100616\n\nStaging an update to the latest fmt version triggered lots of build errors due to non-`const` methods on custom formatters. This fixes the `format()` methods to be `const` as they don't mutate any state anyway, as well as `parse()` methods that don't need to mutate internal state. This mitigates many future build errors.\n\nUpdates were identified and executed by using regular expression search/replacements such as:\n`(constexpr auto parse\\(ParseContext& [^)]*\\)) \\{` -> `$1 const {`\n`(constexpr auto parse\\(ParseContext& [^)]*\\)) ->` -> `$1 const ->`\n`(auto format\\(.*, FormatContext& [^)]*\\)) \\{` -> `$1 const {`\n`(auto format\\(.*, FormatContext& [^)]*\\)) ->` -> `$1 const ->`\n\nAny changes to third-party code was then reverted. Some small changes detected from subsequent build errors were then applied.\n\nTest Plan: CI\n\nDifferential Revision: D45463620\n\nfbshipit-source-id: 6dde77e51fa5145a1113920f062194954284c9af","shortMessageHtmlLink":"[fbcode/caffe2] Make fmt formatter methods const (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1695312190\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pytorch/pytorch/issues/100616\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pytorch/pytorch/pull/100616/hovercard\" href=\"https://github.com/pytorch/pytorch/pull/100616\">pytorch#100616</a>)"}},{"before":"73f66ae0c3ca480140435e656f9c180e9b4f17b3","after":"efad5fdb3d972f5ce76b34aa4948169066a872f2","ref":"refs/heads/export-D45463620","pushedAt":"2023-05-04T23:52:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"scramsby","name":"Scott Ramsby","path":"/scramsby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20998199?s=80&v=4"},"commit":{"message":"[fbcode/caffe2] Make fmt formatter methods const (#100616)\n\nSummary:\nPull Request resolved: https://github.com/pytorch/pytorch/pull/100616\n\nStaging an update to the latest fmt version triggered lots of build errors due to non-`const` methods on custom formatters. This fixes the `format()` methods to be `const` as they don't mutate any state anyway, as well as `parse()` methods that don't need to mutate internal state. This mitigates many future build errors.\n\nUpdates were identified and executed by using regular expression search/replacements such as:\n`(constexpr auto parse\\(ParseContext& [^)]*\\)) \\{` -> `$1 const {`\n`(constexpr auto parse\\(ParseContext& [^)]*\\)) ->` -> `$1 const ->`\n`(auto format\\(.*, FormatContext& [^)]*\\)) \\{` -> `$1 const {`\n`(auto format\\(.*, FormatContext& [^)]*\\)) ->` -> `$1 const ->`\n\nAny changes to third-party code was then reverted. Some small changes detected from subsequent build errors were then applied.\n\nTest Plan: CI\n\nDifferential Revision: D45463620\n\nfbshipit-source-id: 81aa5762adb62ed0bf1a45928ec5ba36f6976dff","shortMessageHtmlLink":"[fbcode/caffe2] Make fmt formatter methods const (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1695312190\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pytorch/pytorch/issues/100616\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pytorch/pytorch/pull/100616/hovercard\" href=\"https://github.com/pytorch/pytorch/pull/100616\">pytorch#100616</a>)"}},{"before":"d1eb00eb84deaf8894591379aa253e97a5985fb4","after":"73f66ae0c3ca480140435e656f9c180e9b4f17b3","ref":"refs/heads/export-D45463620","pushedAt":"2023-05-04T19:33:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"scramsby","name":"Scott Ramsby","path":"/scramsby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20998199?s=80&v=4"},"commit":{"message":"[fbcode/caffe2] Make fmt formatter methods const (#100616)\n\nSummary:\nPull Request resolved: https://github.com/pytorch/pytorch/pull/100616\n\nStaging an update to the latest fmt version triggered lots of build errors due to non-`const` methods on custom formatters. This fixes the `format()` methods to be `const` as they don't mutate any state anyway, as well as `parse()` methods that don't need to mutate internal state. This mitigates many future build errors.\n\nUpdates were identified and executed by using regular expression search/replacements such as:\n`(constexpr auto parse\\(ParseContext& [^)]*\\)) \\{` -> `$1 const {`\n`(constexpr auto parse\\(ParseContext& [^)]*\\)) ->` -> `$1 const ->`\n`(auto format\\(.*, FormatContext& [^)]*\\)) \\{` -> `$1 const {`\n`(auto format\\(.*, FormatContext& [^)]*\\)) ->` -> `$1 const ->`\n\nAny changes to third-party code was then reverted. Some small changes detected from subsequent build errors were then applied.\n\nTest Plan: CI\n\nDifferential Revision: D45463620\n\nfbshipit-source-id: e64b729a0e4f7e841540ccfa09bd06d30da25b1f","shortMessageHtmlLink":"[fbcode/caffe2] Make fmt formatter methods const (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1695312190\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pytorch/pytorch/issues/100616\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pytorch/pytorch/pull/100616/hovercard\" href=\"https://github.com/pytorch/pytorch/pull/100616\">pytorch#100616</a>)"}},{"before":"4993721349ab4b47522c6f016bef810841d75795","after":"d1eb00eb84deaf8894591379aa253e97a5985fb4","ref":"refs/heads/export-D45463620","pushedAt":"2023-05-04T19:24:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"scramsby","name":"Scott Ramsby","path":"/scramsby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20998199?s=80&v=4"},"commit":{"message":"[fbcode/caffe2] Make fmt formatter methods const (#100616)\n\nSummary:\nPull Request resolved: https://github.com/pytorch/pytorch/pull/100616\n\nStaging an update to the latest fmt version triggered lots of build errors due to non-`const` methods on custom formatters. This fixes the `format()` methods to be `const` as they don't mutate any state anyway, as well as `parse()` methods that don't need to mutate internal state. This mitigates many future build errors.\n\nUpdates were identified and executed by using regular expression search/replacements such as:\n`(constexpr auto parse\\(ParseContext& [^)]*\\)) \\{` -> `$1 const {`\n`(constexpr auto parse\\(ParseContext& [^)]*\\)) ->` -> `$1 const ->`\n`(auto format\\(.*, FormatContext& [^)]*\\)) \\{` -> `$1 const {`\n`(auto format\\(.*, FormatContext& [^)]*\\)) ->` -> `$1 const ->`\n\nAny changes to third-party code was then reverted. Some small changes detected from subsequent build errors were then applied.\n\nTest Plan: CI\n\nDifferential Revision: D45463620\n\nfbshipit-source-id: fcadd7f051444a7c7654b1de3b6be6b2adc1bdfa","shortMessageHtmlLink":"[fbcode/caffe2] Make fmt formatter methods const (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1695312190\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pytorch/pytorch/issues/100616\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pytorch/pytorch/pull/100616/hovercard\" href=\"https://github.com/pytorch/pytorch/pull/100616\">pytorch#100616</a>)"}},{"before":null,"after":"4993721349ab4b47522c6f016bef810841d75795","ref":"refs/heads/export-D45463620","pushedAt":"2023-05-04T06:00:59.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"scramsby","name":"Scott Ramsby","path":"/scramsby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20998199?s=80&v=4"},"commit":{"message":"[fbcode/caffe2] Make fmt formatter methods const\n\nSummary:\nStaging an update to the latest fmt version triggered lots of build errors due to non-`const` methods on custom formatters. This fixes the `format()` methods to be `const` as they don't mutate any state anyway, as well as `parse()` methods that don't need to mutate internal state. This mitigates many future build errors.\n\nUpdates were identified and executed by using regular expression search/replacements such as:\n`(constexpr auto parse\\(ParseContext& [^)]*\\)) \\{` -> `$1 const {`\n`(constexpr auto parse\\(ParseContext& [^)]*\\)) ->` -> `$1 const ->`\n`(auto format\\(.*, FormatContext& [^)]*\\)) \\{` -> `$1 const {`\n`(auto format\\(.*, FormatContext& [^)]*\\)) ->` -> `$1 const ->`\n\nAny changes to third-party code was then reverted. Some small changes detected from subsequent build errors were then applied.\n\nTest Plan: CI\n\nDifferential Revision: D45463620\n\nfbshipit-source-id: 4809c110ffc66dbf4f953b18465acf9b9c6798f8","shortMessageHtmlLink":"[fbcode/caffe2] Make fmt formatter methods const"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADJvsSIgA","startCursor":null,"endCursor":null}},"title":"Activity · scramsby/pytorch"}