Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect location parsing #203

Closed
rgreinho opened this issue Sep 30, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@rgreinho
Copy link
Member

@rgreinho rgreinho commented Sep 30, 2019

Issue Type

  • Bug report

Current Behavior

In http://austintexas.gov/news/traffic-fatality-39-3, The value of thelocation field is merged the value of the following fields Vehicle and Driver.

{
    "case": "18-2130392",
    "crash": 39,
    "date": "08/01/2018",
    "fatalities": [
      {
        "age": 0,
        "dob": "11/15/1977",
        "ethnicity": "Hispanic",
        "first": "Ernesto",
        "gender": "Male",
        "generation": "",
        "last": "Garcia",
        "middle": "Gonzales"
      }
    ],
    "latitude": 0.0,
    "link": "http://austintexas.gov/news/traffic-fatality-39-3",
    "location": "600 block of W. Ben White 2005 GMC 1500, TXLP# AD68179 Darrell Shane Smitty, W/M, 52-years-old",
    "longitude": 0.0,
    "notes": "Both the suspect vehicle and suspect are now in the Austin Police Department's (APD) custody from yesterday's fatal crash incident that occurred in the 600 block of W. Ben White. Suspect Darrell Smitty, 52, booking photo is pictured below. He's being charged with failure to stop and render aid. \n\tNote: Booking photo is from a 2016 arrest. \n\n\n\tThe preliminary investigation shows that a pedestrian, identified as 40-year-old Ernesto Garcia, was walking westbound near a bus stop in the 600 block of W. Ben White Service Road. The suspect driver was westbound on the service road in the right turn lane. The suspect drove straight through the intersection, onto the sidewalk, between the bus stop and a Capital Metro bus that had stopped to pick up passengers, striking the pedestrian. \n\tErnesto Garcia was pronounced deceased at the scene. \n\tThe truck came to a stop in a driveway the driver walked to where Garcia lay, then walked back to his truck and drove away. \n\tThis is Austin's 39th fatal traffic crash and 40th traffic fatality of 2018. At this time in 2017, there were 34 fatal traffic crashes and 26 traffic fatalities. This case is still being investigated.",
    "time": "07:58 AM"
  }

Expected Behavior

The fields should not merge together.

@rgreinho rgreinho added the kind/bug label Sep 30, 2019
@rgreinho rgreinho added this to To do in ScrAPD 3.0.0 Sep 30, 2019
@rgreinho rgreinho added this to the ScrAPD 3 milestone Oct 2, 2019
@rgreinho rgreinho moved this from To do to In progress in ScrAPD 3.0.0 Oct 3, 2019
@rgreinho rgreinho self-assigned this Oct 3, 2019
@rgreinho

This comment has been minimized.

Copy link
Member Author

@rgreinho rgreinho commented Oct 4, 2019

Fixed in master (d938b55, 2019-10-03), with no parsing errors being reported in the logs:

[
  {
    "case": "18-2130392",
    "crash": 39,
    "date": "08/01/2018",
    "fatalities": [
      {
        "age": 40,
        "dob": "11/15/1977",
        "ethnicity": "Hispanic",
        "first": "Ernesto",
        "gender": "Male",
        "generation": "",
        "last": "Garcia",
        "middle": "Gonzales"
      }
    ],
    "latitude": 0.0,
    "link": "http://austintexas.gov/news/traffic-fatality-39-3",
    "location": "600 block of W. Ben White",
    "longitude": 0.0,
    "notes": "Both the suspect vehicle and suspect are now in the Austin Police Department's (APD) custody from yesterday's fatal crash incident that occurred in the 600 block of W. Ben White. Suspect Darrell Smitty, 52, booking photo is pictured below. He's being charged with failure to stop and render aid. \n\tNote: Booking photo is from a 2016 arrest. \n\n\n\tThe preliminary investigation shows that a pedestrian, identified as 40-year-old Ernesto Garcia, was walking westbound near a bus stop in the 600 block of W. Ben White Service Road. The suspect driver was westbound on the service road in the right turn lane. The suspect drove straight through the intersection, onto the sidewalk, between the bus stop and a Capital Metro bus that had stopped to pick up passengers, striking the pedestrian. \n\tErnesto Garcia was pronounced deceased at the scene. \n\tThe truck came to a stop in a driveway the driver walked to where Garcia lay, then walked back to his truck and drove away. \n\tThis is Austin's 39th fatal traffic crash and 40th traffic fatality of 2018. At this time in 2017, there were 34 fatal traffic crashes and 26 traffic fatalities. This case is still being investigated.",
    "time": "07:58 AM"
  }
]
@rgreinho rgreinho closed this Oct 4, 2019
ScrAPD 3.0.0 automation moved this from In progress to Done Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
ScrAPD 3.0.0
  
Done
1 participant
You can’t perform that action at this time.