Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date filtering fetches too many pages. #28

Closed
rgreinho opened this issue Jan 26, 2019 · 1 comment
Closed

Date filtering fetches too many pages. #28

rgreinho opened this issue Jan 26, 2019 · 1 comment
Assignees

Comments

@rgreinho
Copy link
Member

@rgreinho rgreinho commented Jan 26, 2019

Issue Type

  • Bug report

Current Behavior

The date filtering does not work as expected.

This request retrieves the fatalities since yesterday:

scrapd -vv retrieve --from=$(date -v-1d +%F)

It should stop fetching results after page 2, but continues until there are no pages left. The output is correct however.

Expected Behavior

The process should stop after fetching page 2 as no result after that can be within the correct time range.

@rgreinho rgreinho added the bug label Jan 26, 2019
@rgreinho rgreinho self-assigned this Jan 26, 2019
@rgreinho rgreinho mentioned this issue Jan 29, 2019
2 tasks
@rgreinho
Copy link
Member Author

@rgreinho rgreinho commented Jan 29, 2019

Fixed by #30

@rgreinho rgreinho closed this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant