Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries when fetching data #116

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
2 participants
@rgreinho
Copy link
Member

commented May 1, 2019

Types of changes

  • Code cleanup / Refactoring

Description

Adds retries to the function retrieving the detailed pages and
extracting the information.

Checklist:

  • I have updated the documentation accordingly
  • I have written unit tests

Fixes #96

Add retries when fetching data
Adds retries to the function retrieving the detailed pages and
extracting the information.

Fixes #96

@rgreinho rgreinho self-assigned this May 1, 2019

@rgreinho rgreinho requested a review from mrengler May 1, 2019

@mrengler
Copy link
Contributor

left a comment

Name                        Stmts   Miss  Cover   Missing
---------------------------------------------------------
scrapd/core/apd.py            279      0   100%
scrapd/core/date_utils.py      37      0   100%
scrapd/core/gsheets.py         27      0   100%
---------------------------------------------------------
TOTAL                         343      0   100%

💯 💯 💯

@mergify mergify bot merged commit 4181807 into scrapd:master May 2, 2019

7 checks passed

Mergify — Summary 1 rule matches
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prepare Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.