Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove lxml as a dependency #117
Conversation
rgreinho
self-assigned this
May 8, 2019
rgreinho
requested a review
from
mrengler
May 9, 2019
mrengler
approved these changes
May 10, 2019
mergify
bot
merged commit c3c9807
into
scrapd:master
May 10, 2019
8 checks passed
Summary
1 rule matches
Details
ci/circleci: docs
Your tests passed on CircleCI!
Details
ci/circleci: format
Your tests passed on CircleCI!
Details
ci/circleci: lint
Your tests passed on CircleCI!
Details
ci/circleci: prepare
Your tests passed on CircleCI!
Details
ci/circleci: test-integrations
Your tests passed on CircleCI!
Details
ci/circleci: test-units
Your tests passed on CircleCI!
Details
coverage/coveralls
Coverage remained the same at 100.0%
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rgreinho commentedMay 8, 2019
Types of changes
Description
Replaces lxml by regexes.
Checklist:
Fixes #101