Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lxml as a dependency #117

Merged
merged 1 commit into from May 10, 2019

Conversation

Projects
None yet
2 participants
@rgreinho
Copy link
Member

commented May 8, 2019

Types of changes

  • Code cleanup / Refactoring

Description

Replaces lxml by regexes.

Checklist:

  • [] I have updated the documentation accordingly
  • [] I have written unit tests

Fixes #101

Remove lxml as a dependency
Replaces lxml by regexes.

Fixes #101

@rgreinho rgreinho self-assigned this May 8, 2019

@rgreinho rgreinho requested a review from mrengler May 9, 2019

@mergify mergify bot merged commit c3c9807 into scrapd:master May 10, 2019

8 checks passed

Summary 1 rule matches
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prepare Your tests passed on CircleCI!
Details
ci/circleci: test-integrations Your tests passed on CircleCI!
Details
ci/circleci: test-units Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.