Types of changes
I added an alternate parsing function for Deceased fields with no DOB available. Also, I changed the existing parsing functions to convert date strings to datetimes earlier, and then changed the lines that compared datetimes to use < and <= instead of the custom functions is_posterior and is_in_range. (The docstring for is_posterior seems to be wrong about what the function does, but I tried to match its actual functionality.)
This is to fix issue #92, Deceased fields that can't be parsed because they contain no DOB.
I added one new test case with the Deceased field that was failing. That one is passing. There's still one record that's failing and showing age -1, but that seems to be a different issue, involving a DOB format with spaces in it. I also changed some tests to expect datetimes instead of strings.
By the way, I accidentally added these commits on top of my old commits that aren't relevant to this pull request, but I decided to submit the pull request anyway before I make it worse in an attempt to modify the git history. The overall diff for the pull request looks correct to me.
The text was updated successfully, but these errors were encountered:
Hmm, I didn't know there were no tests for those formatters. I added some, but not for the Google Sheets formatter because I don't really understand its requirements. So I don't know whether this PR breaks your Google Sheets workflow, @rgreinho. Could you maybe tell me whether it does, or write a test describing the expected behavior?
About the custom operator functions I want to delete...I think a big advantage of using the builtin operator functions is that you don't have to test or document them.
I do agree that