Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Formatters to coverage #133

Merged
merged 1 commit into from May 26, 2019
Merged

Conversation

@rgreinho
Copy link
Member

@rgreinho rgreinho commented May 24, 2019

Types of changes

  • Code cleanup / Refactoring
  • Documentation

Description

Bring formatters to 100% test coverage.

Drive-by:

  • Remove GSheet formatter
  • Remove unused functions and dependencies

Checklist:

  • I have updated the documentation accordingly
  • I have written unit tests
@rgreinho rgreinho self-assigned this May 24, 2019
@rgreinho rgreinho requested a review from mrengler May 24, 2019
Bring formatters to 100% test coverage.

Drive-by:
* Remove GSheet formatter
* Remove unused functions and dependencies
@rgreinho rgreinho force-pushed the formatters-coverage branch from 92d8ba7 to 4a7ec16 May 24, 2019
@rgreinho rgreinho merged commit 5bb0601 into scrapd:master May 26, 2019
8 checks passed
@rgreinho rgreinho deleted the formatters-coverage branch May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant