Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore generation suffixes when parsing names #137

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
1 participant
@rgreinho
Copy link
Member

commented Jun 6, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Description

Generation suffixes like 'Jr.' or 'Sr.' were confused by the parser as
last names, which ended in incorrect data.

Drive-by:

  • Remove unnecessary CLI flags.

Checklist:

  • I have updated the documentation accordingly
  • I have written unit tests

Fixes #99

Ignore generation suffixes when parsing names
Generation suffixes like 'Jr.' or 'Sr.' were confused by the parser as
last names, which ended in incorrect data.

Drive-by:
* Remove unnecessary CLI flags.

Fixes scrapd/scrapd/99

@rgreinho rgreinho self-assigned this Jun 6, 2019

@rgreinho rgreinho merged commit 9b9174c into scrapd:master Jun 6, 2019

8 checks passed

Summary 1 potential rule
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prepare Your tests passed on CircleCI!
Details
ci/circleci: test-integrations Your tests passed on CircleCI!
Details
ci/circleci: test-units Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@rgreinho rgreinho deleted the rgreinho:issues/99/generation-suffixes branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.