Skip to content
This repository has been archived by the owner on Feb 2, 2022. It is now read-only.

Ignore generation suffixes when parsing names #137

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

rgreinho
Copy link
Member

@rgreinho rgreinho commented Jun 6, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Description

Generation suffixes like 'Jr.' or 'Sr.' were confused by the parser as
last names, which ended in incorrect data.

Drive-by:

  • Remove unnecessary CLI flags.

Checklist:

  • I have updated the documentation accordingly
  • I have written unit tests

Fixes #99

Generation suffixes like 'Jr.' or 'Sr.' were confused by the parser as
last names, which ended in incorrect data.

Drive-by:
* Remove unnecessary CLI flags.

Fixes scrapd/scrapd/99
@rgreinho rgreinho self-assigned this Jun 6, 2019
@rgreinho rgreinho merged commit 9b9174c into scrapd:master Jun 6, 2019
@rgreinho rgreinho deleted the issues/99/generation-suffixes branch June 6, 2019 03:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suffixes are used instead of last names
1 participant