Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract logic to parse location field #138

Merged
merged 1 commit into from Jun 9, 2019

Conversation

Projects
None yet
1 participant
@rgreinho
Copy link
Member

commented Jun 7, 2019

Types of changes

  • Code cleanup / Refactoring

Description

Extracts the logic to parse the location field to its own function.

Checklist:

  • I have updated the documentation accordingly
  • I have written unit tests

Fixes spcrapd/scrapd#108

@rgreinho rgreinho self-assigned this Jun 7, 2019

@rgreinho rgreinho requested a review from mrengler Jun 7, 2019

Extract logic to parse location field
Extracts the logic to parse the location field to its own function.

Fixes spcrapd/scrapd#108

@rgreinho rgreinho force-pushed the rgreinho:issues/108/location-field branch from d812c13 to 3825406 Jun 8, 2019

@rgreinho rgreinho referenced this pull request Jun 8, 2019

Closed

APD.py code cleanup #98

@rgreinho rgreinho merged commit 2702523 into scrapd:master Jun 9, 2019

8 checks passed

Summary 1 potential rule
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prepare Your tests passed on CircleCI!
Details
ci/circleci: test-integrations Your tests passed on CircleCI!
Details
ci/circleci: test-units Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@rgreinho rgreinho deleted the rgreinho:issues/108/location-field branch Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.