Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract logic to parse location field #138

merged 1 commit into from Jun 9, 2019


Copy link

@rgreinho rgreinho commented Jun 7, 2019

Types of changes

  • Code cleanup / Refactoring


Extracts the logic to parse the location field to its own function.


  • I have updated the documentation accordingly
  • I have written unit tests

Fixes spcrapd/scrapd#108

@rgreinho rgreinho self-assigned this Jun 7, 2019
@rgreinho rgreinho requested a review from mrengler Jun 7, 2019
Extracts the logic to parse the location field to its own function.

Fixes spcrapd/scrapd#108
@rgreinho rgreinho force-pushed the issues/108/location-field branch from d812c13 to 3825406 Jun 8, 2019
@rgreinho rgreinho mentioned this pull request Jun 8, 2019
@rgreinho rgreinho merged commit 2702523 into scrapd:master Jun 9, 2019
8 checks passed
@rgreinho rgreinho deleted the issues/108/location-field branch Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant