Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure no field is empty #139

merged 1 commit into from Jun 9, 2019


Copy link

@rgreinho rgreinho commented Jun 7, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)


Validates the field values to make sure than none of them is empty.


  • I have updated the documentation accordingly
  • I have written unit tests

Fixes #118

@rgreinho rgreinho self-assigned this Jun 7, 2019
@rgreinho rgreinho requested a review from mrengler Jun 7, 2019
Validates the field values to make sure than none of them is empty.

Fixes scrapd#118
@rgreinho rgreinho force-pushed the issues/118/no-empty-fields branch from 7a4e6e1 to 85f57ae Jun 8, 2019
@rgreinho rgreinho mentioned this pull request Jun 8, 2019
@rgreinho rgreinho merged commit ec52d24 into scrapd:master Jun 9, 2019
8 checks passed
@rgreinho rgreinho deleted the issues/118/no-empty-fields branch Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant