Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date parsing #155

Merged
merged 8 commits into from Jun 26, 2019

Conversation

@mscarey
Copy link
Contributor

commented Jun 19, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Description

Lets the scraper parse D.O.B. in a format like "March 1, 1990".

Should now parse http://austintexas.gov/news/traffic-fatality-29-3 correctly.

I added a test that the scraper gets the correct D.O.B. using the "Deceased:" line from the APD report as input.

Checklist:

  • [] I have updated the documentation accordingly
  • I have written unit tests

Fixes: #128.

@mscarey mscarey referenced this pull request Jun 20, 2019
@rgreinho

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

Very smart use of the calendar module! I like it 👍

As soon as you update your branch and resolve the conflicts, I'll give you the green light!

mscarey added some commits Jun 20, 2019

@rgreinho

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

@mscarey can you try to run the following commands in your terminal and paste their output please?

yapf --version
yapf -r -i -e "*.nox/*" -e "*.tox/*" -e "*venv/*" -e "*.eggs/*" -vv .

I tested on 2 different laptops and I got the following:

$ yapf --version
yapf 0.27.0
$ yapf -r -i -e "*.nox/*" -e "*.tox/*" -e "*venv/*" -e "*.eggs/*" -vv .
Reformatting ./setup.py
Reformatting ./noxfile.py
Reformatting ./tests/test_common.py
Reformatting ./tests/__init__.py
Reformatting ./tests/mock_data.py
Reformatting ./tests/core/__init__.py
Reformatting ./tests/core/test_apd.py
Reformatting ./tests/core/test_date_utils.py
Reformatting ./tests/core/test_formatters.py
Reformatting ./tests/step_defs/test_retrieve.py
Reformatting ./scrapd/__init__.py
Reformatting ./scrapd/main.py
Reformatting ./scrapd/core/formatter.py
Reformatting ./scrapd/core/version.py
Reformatting ./scrapd/core/apd.py
Reformatting ./scrapd/core/date_utils.py
Reformatting ./scrapd/core/__init__.py
Reformatting ./scrapd/core/constant.py
Reformatting ./scrapd/cli/__init__.py
Reformatting ./scrapd/cli/cli.py
Reformatting ./scrapd/cli/base.py
Reformatting ./docs/source/conf.py
@rgreinho

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

W00t! it worked!

@rgreinho
Copy link
Member

left a comment

👍

@mergify mergify bot merged commit cfc5c7e into scrapd:master Jun 26, 2019

8 checks passed

Summary 1 rule matches
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prepare Your tests passed on CircleCI!
Details
ci/circleci: test-integrations Your tests passed on CircleCI!
Details
ci/circleci: test-units Your tests passed on CircleCI!
Details
security/snyk - requirements.txt (rgreinho) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.