Skip to content
This repository has been archived by the owner on Feb 2, 2022. It is now read-only.

Date parsing #155

Merged
merged 8 commits into from
Jun 26, 2019
Merged

Date parsing #155

merged 8 commits into from
Jun 26, 2019

Conversation

mscarey
Copy link
Contributor

@mscarey mscarey commented Jun 19, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Description

Lets the scraper parse D.O.B. in a format like "March 1, 1990".

Should now parse http://austintexas.gov/news/traffic-fatality-29-3 correctly.

I added a test that the scraper gets the correct D.O.B. using the "Deceased:" line from the APD report as input.

Checklist:

  • [] I have updated the documentation accordingly
  • I have written unit tests

Fixes: #128.

@rgreinho
Copy link
Member

Very smart use of the calendar module! I like it 👍

As soon as you update your branch and resolve the conflicts, I'll give you the green light!

@rgreinho
Copy link
Member

@mscarey can you try to run the following commands in your terminal and paste their output please?

yapf --version
yapf -r -i -e "*.nox/*" -e "*.tox/*" -e "*venv/*" -e "*.eggs/*" -vv .

I tested on 2 different laptops and I got the following:

$ yapf --version
yapf 0.27.0
$ yapf -r -i -e "*.nox/*" -e "*.tox/*" -e "*venv/*" -e "*.eggs/*" -vv .
Reformatting ./setup.py
Reformatting ./noxfile.py
Reformatting ./tests/test_common.py
Reformatting ./tests/__init__.py
Reformatting ./tests/mock_data.py
Reformatting ./tests/core/__init__.py
Reformatting ./tests/core/test_apd.py
Reformatting ./tests/core/test_date_utils.py
Reformatting ./tests/core/test_formatters.py
Reformatting ./tests/step_defs/test_retrieve.py
Reformatting ./scrapd/__init__.py
Reformatting ./scrapd/main.py
Reformatting ./scrapd/core/formatter.py
Reformatting ./scrapd/core/version.py
Reformatting ./scrapd/core/apd.py
Reformatting ./scrapd/core/date_utils.py
Reformatting ./scrapd/core/__init__.py
Reformatting ./scrapd/core/constant.py
Reformatting ./scrapd/cli/__init__.py
Reformatting ./scrapd/cli/cli.py
Reformatting ./scrapd/cli/base.py
Reformatting ./docs/source/conf.py

@rgreinho
Copy link
Member

W00t! it worked!

Copy link
Member

@rgreinho rgreinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit cfc5c7e into scrapd:master Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date of Birth with spaces not being recognized
2 participants