This repository has been archived by the owner on Feb 2, 2022. It is now read-only.
Parametrize retries from the CLI #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds CLI flags to parametrize the number of attempts and the exponential backoff multiplier. Reconfigures the retryer to reraise the last exception instead of raising `RetryError`, as well as changing the strategy to use a backoff multiplier. The wait strategy will now be attempt_number * 3 seconds by default. The documentation was updated accordingly. Fixes scrapd#149 Fixes scrapd#151
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Adds CLI flags to parametrize the number of attempts and the exponential
backoff multiplier.
Reconfigures the retryer to reraise the last exception instead of
raising
RetryError, as well as changing the strategy to use a backoffmultiplier. The wait strategy will now be attempt_number * 3 seconds by
default.
The documentation was updated accordingly.
Checklist:
Fixes #149
Fixes #151