Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize retries from the CLI #159

Merged
merged 1 commit into from Jun 26, 2019

Conversation

@rgreinho
Copy link
Member

@rgreinho rgreinho commented Jun 26, 2019

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Code cleanup / Refactoring
  • Documentation

Description

Adds CLI flags to parametrize the number of attempts and the exponential
backoff multiplier.

Reconfigures the retryer to reraise the last exception instead of
raising RetryError, as well as changing the strategy to use a backoff
multiplier. The wait strategy will now be attempt_number * 3 seconds by
default.

The documentation was updated accordingly.

Checklist:

  • I have updated the documentation accordingly
  • I have written unit tests

Fixes #149
Fixes #151

Adds CLI flags to parametrize the number of attempts and the exponential
backoff multiplier.

Reconfigures the retryer to reraise the last exception instead of
raising `RetryError`, as well as changing the strategy to use a backoff
multiplier. The wait strategy will now be attempt_number * 3 seconds by
default.

The documentation was updated accordingly.

Fixes scrapd#149
Fixes scrapd#151
@rgreinho rgreinho self-assigned this Jun 26, 2019
@rgreinho rgreinho merged commit d08fa27 into scrapd:master Jun 26, 2019
9 checks passed
Loading
@rgreinho rgreinho deleted the issues/149+151/parametrize-cli branch Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant