Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make better regexes and better tests #171

Merged
merged 1 commit into from Jul 5, 2019

Conversation

@rgreinho
Copy link
Member

commented Jul 5, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code cleanup / Refactoring
  • Documentation

Description

  • Update the documentation.
  • Use Python object for time
  • Improve regexes to parse the fields

The tests were updated accordingly.

Checklist:

  • [] I have updated the documentation accordingly
  • [] I have written unit tests
Make better regexes and better tests
* Update the documentation.
* Use Python object for time
* Improve regexes to parse the fields

The tests were updated accordingly.

@rgreinho rgreinho self-assigned this Jul 5, 2019

@rgreinho rgreinho merged commit 911457e into scrapd:master Jul 5, 2019

9 checks passed

Summary 1 potential rule
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prepare Your tests passed on CircleCI!
Details
ci/circleci: test-integrations Your tests passed on CircleCI!
Details
ci/circleci: test-units Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
security/snyk - requirements.txt (rgreinho) No manifest changes detected

@rgreinho rgreinho deleted the rgreinho:better-date-parsing branch Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.