Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement data models #199
Types of changes
Implements data models representing the resources captured by ScrAPD.
As this is a fundamental change, the PR is way bigger than a normal
Implements data models representing the resources captured by ScrAPD. This allows us to validate the data we are extracting, reduces the possibility to introduce incorrect values and prevents polluting the final data set. As this is a fundamental change, the PR is way bigger than a normal one, but the following items were also addressed: * Reorganize the modules based on the resources they process. * Reorganize the unit tests in suites and leverages `pytest.param` objects to assign test IDs and simplify the process of adding markers. * Update the formatters to render the models.
mscarey left a comment
Good job! I like the looks of pydantic, and I'm looking forward to seeing how the new schema works with the viz page. The two comments I made above probably duplicate stuff I've said elsewhere. I think the test coverage issue is the more important one.