Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make report date mandatory #210

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@rgreinho
Copy link
Member

rgreinho commented Oct 4, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Description

The report date is required to be able to filter the reports by date,
which is a key part of our algorithm. Therefore this field was made
required in the Report model.

  • Add more validation
  • Update and add unit tests
  • Fixes the date regex

Checklist:

  • I have updated the documentation accordingly
  • I have written unit tests

Fixes #202
Fixes #209

@rgreinho rgreinho self-assigned this Oct 4, 2019
@rgreinho rgreinho force-pushed the issues/202-209/date-parsing branch from 7b39f7a to e3ef93d Oct 4, 2019
The report date is required to be able to filter the reports by date,
which is a key part of our algorithm. Therefore this field was made
required in the `Report model`.

* Add more validation
* Update and add unit tests
* Fixes the date regex

Fixes #202
Fixes #209
@rgreinho rgreinho force-pushed the issues/202-209/date-parsing branch from e3ef93d to 780bc66 Oct 4, 2019
@rgreinho

This comment has been minimized.

Copy link
Member Author

rgreinho commented Oct 4, 2019

Merging this to move forward. Reopen the associated issue if there is any problem.

@rgreinho rgreinho merged commit d938b55 into master Oct 4, 2019
9 checks passed
9 checks passed
Summary 1 potential rule
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prepare Your tests passed on CircleCI!
Details
ci/circleci: test-integrations Your tests passed on CircleCI!
Details
ci/circleci: test-units Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
security/snyk - requirements.txt (rgreinho) No manifest changes detected
@rgreinho rgreinho deleted the issues/202-209/date-parsing branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.