Skip to content
This repository has been archived by the owner. It is now read-only.

Make report date mandatory #210

Merged
merged 1 commit into from Oct 4, 2019
Merged

Make report date mandatory #210

merged 1 commit into from Oct 4, 2019

Conversation

rgreinho
Copy link
Member

@rgreinho rgreinho commented Oct 4, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Description

The report date is required to be able to filter the reports by date,
which is a key part of our algorithm. Therefore this field was made
required in the Report model.

  • Add more validation
  • Update and add unit tests
  • Fixes the date regex

Checklist:

  • I have updated the documentation accordingly
  • I have written unit tests

Fixes #202
Fixes #209

@rgreinho rgreinho self-assigned this Oct 4, 2019
@rgreinho rgreinho force-pushed the issues/202-209/date-parsing branch from 7b39f7a to e3ef93d Compare Oct 4, 2019
The report date is required to be able to filter the reports by date,
which is a key part of our algorithm. Therefore this field was made
required in the `Report model`.

* Add more validation
* Update and add unit tests
* Fixes the date regex

Fixes #202
Fixes #209
@rgreinho rgreinho force-pushed the issues/202-209/date-parsing branch from e3ef93d to 780bc66 Compare Oct 4, 2019
@rgreinho
Copy link
Member Author

@rgreinho rgreinho commented Oct 4, 2019

Merging this to move forward. Reopen the associated issue if there is any problem.

@rgreinho rgreinho merged commit d938b55 into master Oct 4, 2019
9 checks passed
@rgreinho rgreinho deleted the issues/202-209/date-parsing branch Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant