This repository was archived by the owner on Feb 2, 2022. It is now read-only.
Make report date mandatory #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgreinho
force-pushed
the
issues/202-209/date-parsing
branch
from
7b39f7a to
e3ef93d
Compare
rgreinho
force-pushed
the
issues/202-209/date-parsing
branch
from
e3ef93d to
780bc66
Compare
|
Merging this to move forward. Reopen the associated issue if there is any problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
The report date is required to be able to filter the reports by date,
which is a key part of our algorithm. Therefore this field was made
required in the
Report model.Checklist:
Fixes #202
Fixes #209