Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --dump option #214

Merged
merged 1 commit into from Oct 7, 2019
Merged

Add --dump option #214

merged 1 commit into from Oct 7, 2019

Conversation

@rgreinho
Copy link
Member

@rgreinho rgreinho commented Oct 6, 2019

Types of changes

  • New feature (non-breaking change which adds functionality)

Description

Adds a --dump option to help developers debug parsing issues.

The documentation was updated accordingly and the pytest settings were
adjusted to handle the new marker.

Checklist:

  • I have updated the documentation accordingly
  • I have written unit tests
Adds a `--dump` option to help developers debug parsing issues.

The documentation was updated accordingly and the pytest settings were
adjusted to handle the new marker.
@rgreinho rgreinho requested a review from Oct 6, 2019
@rgreinho rgreinho self-assigned this Oct 6, 2019
Copy link
Contributor

@mscarey mscarey left a comment

On the line assert not twitter_err, it gave me this error:

AssertionError: assert not ['cannot parse deceased: Unidentified female Unidentified male']

No sure what happened there.

@rgreinho
Copy link
Member Author

@rgreinho rgreinho commented Oct 7, 2019

That sounds good. It means in the fatality report you tested, there is a deceased field that we cannot parse.

Issue #201 is about this issue.

mscarey
mscarey approved these changes Oct 7, 2019
@mergify mergify bot merged commit 157beca into scrapd:master Oct 7, 2019
9 checks passed
@rgreinho rgreinho deleted the dump-option branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants