Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unidentified deceased #220

Merged
merged 1 commit into from Oct 23, 2019

Conversation

@rgreinho
Copy link
Member

rgreinho commented Oct 22, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Description

Drive-by:

  • Adds tasks to dump the errors and the data set in JSON and CSV.

Checklist:

  • [] I have updated the documentation accordingly
  • I have written unit tests

Fixes: #201

@rgreinho rgreinho self-assigned this Oct 22, 2019
@rgreinho rgreinho requested a review from mscarey Oct 22, 2019
@rgreinho rgreinho force-pushed the rgreinho:issues/201/unidentified-deceased branch from e3db419 to 67284e1 Oct 22, 2019
@rgreinho rgreinho added the no-mergify label Oct 22, 2019
@rgreinho

This comment has been minimized.

Copy link
Member Author

rgreinho commented Oct 22, 2019

Thinking about this over night, parse_unidentified() should probably raise ValueError when no data is found instead of returning an empty array. This found be more consistent with the previous functions and would prevent this function to act as a "catch all" when the parsing fails.

I'll make the necessary adjustments soon.

Drive-by:
* Adds tasks to dump the errors and the data set in JSON and CSV.

Fixes #201
@rgreinho rgreinho force-pushed the rgreinho:issues/201/unidentified-deceased branch from 67284e1 to e6b16c9 Oct 22, 2019
@rgreinho rgreinho removed the no-mergify label Oct 22, 2019
@rgreinho

This comment has been minimized.

Copy link
Member Author

rgreinho commented Oct 22, 2019

Alright! Ready for review @mscarey!

Copy link
Contributor

mscarey left a comment

Looks good

@mergify mergify bot merged commit a3f7697 into scrapd:master Oct 23, 2019
9 checks passed
9 checks passed
Summary 1 rule matches
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prepare Your tests passed on CircleCI!
Details
ci/circleci: test-integrations Your tests passed on CircleCI!
Details
ci/circleci: test-units Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
security/snyk - requirements.txt (rgreinho) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.