Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing with arrested field #224

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@rgreinho
Copy link
Member

rgreinho commented Oct 24, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Description

Articles containing an "Arrested" field were not parsed correctly and
the information about the person who got arrested was injected into the
deceased field.

Checklist:

  • [] I have updated the documentation accordingly
  • I have written unit tests

Fixes #205

@rgreinho rgreinho self-assigned this Oct 24, 2019
@rgreinho rgreinho requested a review from mscarey Oct 24, 2019
@rgreinho rgreinho force-pushed the rgreinho:issues/205/with-arrested-field branch from 7281d4d to 885a7d0 Oct 30, 2019
Articles containing an "Arrested" field where not parsed correctly and
the information about the person who got arrested was injected into the
deceased field.

Fixes #205
@rgreinho rgreinho force-pushed the rgreinho:issues/205/with-arrested-field branch from 885a7d0 to c9ab34f Oct 30, 2019
@rgreinho rgreinho merged commit 4d8f5f7 into scrapd:master Oct 31, 2019
9 checks passed
9 checks passed
Summary 1 potential rule
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prepare Your tests passed on CircleCI!
Details
ci/circleci: test-integrations Your tests passed on CircleCI!
Details
ci/circleci: test-units Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
security/snyk - requirements.txt (rgreinho) No manifest changes detected
@rgreinho rgreinho deleted the rgreinho:issues/205/with-arrested-field branch Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.