Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect deceased w/ arrested field parsing #227

Merged
merged 1 commit into from Nov 30, 2019

Conversation

@rgreinho
Copy link
Member

rgreinho commented Nov 28, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Description

Fixes the parsing logic to correctly ignore the Arrested field instead
of injected it into the middle name field.

Checklist:

  • [] I have updated the documentation accordingly
  • I have written unit tests

Fixes #226

@rgreinho rgreinho self-assigned this Nov 28, 2019
@rgreinho rgreinho force-pushed the rgreinho:issues/226/wrong-arrested-parsing branch from a2d13bf to 011539c Nov 28, 2019
Fixes the parsing logic to correctly ignore the `Arrested` field instead
of injected it into the middle name field.

Fixes #226
@rgreinho rgreinho force-pushed the rgreinho:issues/226/wrong-arrested-parsing branch from 011539c to bb63598 Nov 29, 2019
@rgreinho rgreinho merged commit 4e7c141 into scrapd:master Nov 30, 2019
9 checks passed
9 checks passed
Summary 1 potential rule
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prepare Your tests passed on CircleCI!
Details
ci/circleci: test-integrations Your tests passed on CircleCI!
Details
ci/circleci: test-units Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
security/snyk - requirements.txt (rgreinho) No manifest changes detected
@rgreinho rgreinho deleted the rgreinho:issues/226/wrong-arrested-parsing branch Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.