Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle new page title #230

Merged
merged 1 commit into from Jan 11, 2020
Merged

Handle new page title #230

merged 1 commit into from Jan 11, 2020

Conversation

@rgreinho
Copy link
Member

rgreinho commented Jan 10, 2020

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Description

For some unknown reason, even though I tried very hard to understand the
reasoning behind it, APD decided to change the title of the traffic
fatality pages to "Fatality Crash"...

In spite of the lack of common sense regarding this decision, this patch
accommodates the situation and fixes the parsing.

Checklist:

  • [] I have updated the documentation accordingly
  • I have written unit tests
For some unknown reason, even though I tried very hard to understand the
reasoning behind it, APD decided to change the title of the traffic
fatality pages to "Fatality Crash"...

In spite of the lack of common sense regarding this decision, this patch
accommodates the situation and fixes the parsing.
@rgreinho rgreinho added the kind/bug label Jan 10, 2020
@rgreinho rgreinho requested a review from mscarey Jan 10, 2020
@rgreinho rgreinho self-assigned this Jan 10, 2020
Copy link
Contributor

mscarey left a comment

The changes look good. Thanks for noticing the scraper needed the update. I haven't kept up with it lately...just went to viz.scrapd.org and was surprised not to see a link to the live viz.

@mergify mergify bot merged commit e6330d9 into master Jan 11, 2020
9 checks passed
9 checks passed
Summary 1 rule matches
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prepare Your tests passed on CircleCI!
Details
ci/circleci: test-integrations Your tests passed on CircleCI!
Details
ci/circleci: test-units Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
security/snyk - requirements.txt (rgreinho) No manifest changes detected
@rgreinho rgreinho deleted the fix-filter branch Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.