Skip to content
This repository has been archived by the owner on Feb 2, 2022. It is now read-only.

Handle new page title #230

Merged
merged 1 commit into from
Jan 11, 2020
Merged

Handle new page title #230

merged 1 commit into from
Jan 11, 2020

Conversation

rgreinho
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Description

For some unknown reason, even though I tried very hard to understand the
reasoning behind it, APD decided to change the title of the traffic
fatality pages to "Fatality Crash"...

In spite of the lack of common sense regarding this decision, this patch
accommodates the situation and fixes the parsing.

Checklist:

  • [] I have updated the documentation accordingly
  • I have written unit tests

For some unknown reason, even though I tried very hard to understand the
reasoning behind it, APD decided to change the title of the traffic
fatality pages to "Fatality Crash"...

In spite of the lack of common sense regarding this decision, this patch
accommodates the situation and fixes the parsing.
@rgreinho rgreinho added the kind/bug Something isn't working label Jan 10, 2020
@rgreinho rgreinho requested a review from mscarey January 10, 2020 23:30
@rgreinho rgreinho self-assigned this Jan 10, 2020
Copy link
Contributor

@mscarey mscarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Thanks for noticing the scraper needed the update. I haven't kept up with it lately...just went to viz.scrapd.org and was surprised not to see a link to the live viz.

@mergify mergify bot merged commit e6330d9 into master Jan 11, 2020
@rgreinho rgreinho deleted the fix-filter branch January 11, 2020 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants