Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fatality link detection #44

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
None yet
1 participant
@rgreinho
Copy link
Collaborator

commented Feb 22, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Description

The function to detect fatality detail pages was improved to better
find them.

This lead to improving the twitter description parsing.

Checklist:

  • [] I have updated the documentation accordingly
  • I have written unit tests

@rgreinho rgreinho self-assigned this Feb 22, 2019

@rgreinho rgreinho force-pushed the invalid-data branch from d688a3a to 7243990 Feb 22, 2019

Fix fatality link detection
The function to detect fatality detail pages was improved to better
find them.

This lead to improving the twitter description parsing.

@rgreinho rgreinho force-pushed the invalid-data branch from 7243990 to 67a3a62 Feb 22, 2019

@rgreinho rgreinho merged commit 3eaa7f7 into master Feb 22, 2019

7 checks passed

Mergify — Summary 1 potential rule
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prepare Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
coverage/coveralls Coverage increased (+0.08%) to 96.38%
Details

@rgreinho rgreinho deleted the invalid-data branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.