Join GitHub today
Make sure date string format is consistent #57
Types of changes
Added function in date_utils.py to convert any parse-able date string into the desired format dd-mm-YYYY. Added call to that function as part of sanitize_fatality_entity() in apd.py.
These changes ensure that the dates returned will all be formatted the same, improving readability.
Good job on your first PR @mrengler! It looks very good.
I apologize again for the mistake I made in the issue regarding the date format. Luckily it is an easy one to fix.
Aside of that, just a few minor remarks:
And at the end of the CHANGELOG, add a link to the issue: