This repository has been archived by the owner on Feb 2, 2022. It is now read-only.
Add retry mechanism to fetch_text
#85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgreinho
force-pushed
the
issues/83/fecth-page-retry
branch
3 times, most recently
from
3d234b2
to
a4a4f24
Compare
Sometimes the `fetch_text` function does not succeed to retrieve data and makes ScrAPD crash. This patch adds a retry mechanism to this function, with exponential backoff, and simply raises a `ValueError` exception if it really cannot retrieve any data. Fixes scrapd#83
rgreinho
force-pushed
the
issues/83/fecth-page-retry
branch
from
a4a4f24
to
c72dad8
Compare
mrengler
reviewed
Apr 19, 2019
| @@ -15,6 +18,7 @@ | |||
| PAGE_DETAILS_URL = 'http://austintexas.gov/' | |||
|
|
|||
|
|
|||
| @retry(stop=stop_after_attempt(3), wait=wait_exponential(multiplier=1, min=4, max=10)) | |||
There was a problem hiding this comment.
Have we seen any examples of >3 failures? I'm not sure how rare it is but that seems safe to me.
There was a problem hiding this comment.
We have not because it currently fails at the first one. If we see more failures, I'll readjust the parameters (more retries, more wait).
mrengler
approved these changes
Apr 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Sometimes the
fetch_textfunction does not succeed to retrieve dataand makes ScrAPD crash. This patch adds a retry mechanism to this
function, with exponential backoff, and simply raises a
ValueErrorexception if it really cannot retrieve any data.
Checklist:
Fixes #83