Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link to settings section in README.rst #1018

merged 1 commit into from Nov 19, 2021

fix link to settings section in README.rst #1018

merged 1 commit into from Nov 19, 2021


Copy link

@o-wo o-wo commented Nov 17, 2021


I observed that in README, current URL for settings section of the docs leads to usage section, so this PR fixes the URL to properly redirect the readers to correct settings section of dateparser docs.

P.S. thank you for creating dateparser! ❤️

Copy link

@lopuhin lopuhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the catch @ow0x

Copy link

lopuhin commented Nov 19, 2021

let me just make sure tests pass

Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #1018 (4c905f2) into master (5ec1a6e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1018   +/-   ##
  Coverage   98.29%   98.29%           
  Files         234      234           
  Lines        2694     2694           
  Hits         2648     2648           
  Misses         46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ec1a6e...4c905f2. Read the comment docs.

@lopuhin lopuhin merged commit ff439d1 into scrapinghub:master Nov 19, 2021
10 checks passed
@o-wo o-wo deleted the patch-1 branch November 19, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants