Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix directories creation error #1022

Merged
merged 1 commit into from Dec 15, 2021
Merged

Fix directories creation error #1022

merged 1 commit into from Dec 15, 2021

Conversation

Laerte
Copy link
Contributor

@Laerte Laerte commented Nov 25, 2021

This fix #1021

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #1022 (4182de2) into master (ff439d1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1022   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         234      234           
  Lines        2694     2694           
=======================================
  Hits         2648     2648           
  Misses         46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff439d1...4182de2. Read the comment docs.

Copy link
Member

@lopuhin lopuhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix @Laerte

@lopuhin lopuhin merged commit 4490ca6 into scrapinghub:master Dec 15, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_data_model_home() fails without ~/.cache
2 participants