Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves Croatian support. #1073

Merged
merged 2 commits into from Oct 12, 2022
Merged

Improves Croatian support. #1073

merged 2 commits into from Oct 12, 2022

Conversation

cyanic-selkie
Copy link
Contributor

@cyanic-selkie cyanic-selkie commented Aug 30, 2022

This PR adds better support for Croatian. Mainly improves morphological variant coverage and adds a few additional relative forms.

@cyanic-selkie cyanic-selkie requested review from LRepalust and removed request for serhii73 October 11, 2022 08:22
Copy link

@LRepalust LRepalust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 98.29% // Head: 98.23% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (25b8746) compared to base (ffb9a2d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1073      +/-   ##
==========================================
- Coverage   98.29%   98.23%   -0.07%     
==========================================
  Files         234      232       -2     
  Lines        2702     2599     -103     
==========================================
- Hits         2656     2553     -103     
  Misses         46       46              
Impacted Files Coverage Δ
dateparser/data/date_translation_data/hr.py 100.00% <ø> (ø)
dateparser/data/date_translation_data/uk.py 100.00% <ø> (ø)
dateparser/utils/__init__.py 95.27% <0.00%> (ø)
dateparser/__init__.py
dateparser/conf.py
dateparser/date.py 99.27% <0.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gallaecio Gallaecio merged commit d1ab41f into scrapinghub:master Oct 12, 2022
9 of 10 checks passed
@Gallaecio
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants