Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use month with 31 days to avoid test failures #1086

Merged
merged 1 commit into from Oct 18, 2022

Conversation

gutsytechster
Copy link
Collaborator

@gutsytechster gutsytechster commented Oct 17, 2022

The test fails on the 31st of any month since the set month in the test doesn't have the 31st date. We fix this by using the month with 31 days.

Fixes #1053

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 98.23% // Head: 98.23% // No change to project coverage 👍

Coverage data is based on head (1369aa2) compared to base (c30d8c0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1086   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         232      232           
  Lines        2599     2599           
=======================================
  Hits         2553     2553           
  Misses         46       46           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gallaecio Gallaecio merged commit b132381 into scrapinghub:master Oct 18, 2022
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail on 31st of a month
2 participants