Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defined encoding to utf-8 which was causing decode error in windows #998

Merged
merged 1 commit into from Dec 14, 2021

Conversation

atharmohammad
Copy link
Contributor

Closes #978

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #998 (a92b20c) into master (ff439d1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #998   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         234      234           
  Lines        2694     2694           
=======================================
  Hits         2648     2648           
  Misses         46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff439d1...a92b20c. Read the comment docs.

setup.py Outdated
@@ -5,7 +5,7 @@
open('dateparser/__init__.py').read()).group(1)

introduction = re.sub(r':members:.+|..\sautomodule::.+|:class:|:func:|:ref:',
'', open('docs/introduction.rst').read())
'', open('docs/introduction.rst', encoding='utf-8').read())
history = re.sub(r':mod:|:class:|:func:', '', open('HISTORY.rst').read())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you will also need to add utf-8 encoding for HISTORY.rst as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! you are correct. Thanks 😄

Copy link
Member

@lopuhin lopuhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR @atharmohammad and sorry for a late review. It looks great, but in e14655b the line endings in setup.py are changed, so the diff is showing that the whole file is changed (the line endings don't show up on github but are visible in the command line git). Would you mind fixing this?

@atharmohammad
Copy link
Contributor Author

Thanks for PR @atharmohammad and sorry for a late review. It looks great, but in e14655b the line endings in setup.py are changed, so the diff is showing that the whole file is changed (the line endings don't show up on github but are visible in the command line git). Would you mind fixing this?

Yeah! Sure. Fixing it

@atharmohammad
Copy link
Contributor Author

@lopuhin have done the changes please have a look !

Copy link
Member

@lopuhin lopuhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @atharmohammad 👍

@lopuhin lopuhin merged commit 300b11c into scrapinghub:master Dec 14, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants