Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(scripting): add Element class with `offset` method #422
I've tried to implement Element class suggested in #380
local element = splash:select('.container .title')
In this PR I've implemented only 1 method for this class: #offset. It returns a dictionary with top and left offset value like in jQuery#offset method.
There is no tests and docs update. Only one script example. I'll write them if my assumptions what'd be done is right.
Is this what #380 have suggested or I'm going to the wrong direction?
P.S. This PR was creating for my proposal for GSoC 2016.
Current coverage is
The PR looks fine for what it does, but I'm reclucant to merge it without a clear vision on API we're going to provide. You're asking right questions in #380 (comment), but there are more of them, e.g.: