New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wraputils.setup_commands store private methods in the instance itself rather than in the separate table #487

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mike1808
Contributor

mike1808 commented Jul 26, 2016

No description provided.

@mike1808 mike1808 changed the title from store private methods in the instance itself rather than in the separate table to wraputils.setup_commands store private methods in the instance itself rather than in the separate table Jul 26, 2016

@@ -25,7 +24,7 @@ end
-- It is required to handle errors properly.
--
function Splash:jsfunc(...)
local func = Splash_private.jsfunc(self, ...)
local func = self.__private.jsfunc(self, ...)

This comment has been minimized.

@kmike

kmike Jul 26, 2016

Member

They are private because users shouldn't be able to access them; it seems that adding __private attribute breaks that.

@kmike

kmike Jul 26, 2016

Member

They are private because users shouldn't be able to access them; it seems that adding __private attribute breaks that.

This comment has been minimized.

@mike1808

mike1808 Jul 26, 2016

Contributor

In that case we should fix drops_self_argument because it make useless the usage of self.

@mike1808

mike1808 Jul 26, 2016

Contributor

In that case we should fix drops_self_argument because it make useless the usage of self.

@kmike

This comment has been minimized.

Show comment
Hide comment
@kmike

kmike Sep 9, 2016

Member

Fixed by #495.

Member

kmike commented Sep 9, 2016

Fixed by #495.

@kmike kmike closed this Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment