allow to define field extractors over text contents only, without need to re parsing. #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrapely/htmlpage.py
Outdated
Member
There was a problem hiding this comment.
why call text_all.strip() instead of simply passing text_all? do we need to remove whitespace?
Contributor
Author
There was a problem hiding this comment.
Yes, strictly there is no need to make a strip. I will remove.
…d to re parsing. Added tests and fixed current ones, as a special flag was added on HtmlDataFragment objects
Contributor
Author
|
I made the changes you suggested. please check. |
shaneaevans
added a commit
that referenced
this pull request
Feb 16, 2012
allow defining of field extractors over text content only, without the need to re-parse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to define field extractors over text contents only, without need to re parsing. Added tests and fixed current ones, as a special flag was added on HtmlDataFragment objects