Simplifying the test_extraction code and a few clean ups #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameterized, make the actual test code quite clear
Contributor
Author
There was a problem hiding this comment.
Adding an external dependency, which you may want to avoid.
Since nose doesn't allow you to generate unittests on a TestCase class with yield, I used nose-parameterized to do the test generation for me. The previous revision, however, keeps the original assert style but moves the tests to the module level so the test generation will work.
pablohoffman
added a commit
that referenced
this pull request
Aug 26, 2013
Simplifying the test_extraction code and a few clean ups
Member
|
Thanks @AlexRiina, it's definitely a good cleanup. I hope you are just setting up the environment in preparation for more contributions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.