Skip to content
Permalink
Browse files

fix scrapy squeue tests after recent changes to queuelib

  • Loading branch information
dangra committed Sep 9, 2015
1 parent 2d688cd commit 3365c0151464b77c3da6538c2d29cd6b7946c892
Showing with 4 additions and 4 deletions.
  1. +4 −4 tests/test_squeues.py
@@ -19,7 +19,7 @@ class MarshalFifoDiskQueueTest(t.FifoDiskQueueTest):
chunksize = 100000

def queue(self):
return MarshalFifoDiskQueue(self.qdir, chunksize=self.chunksize)
return MarshalFifoDiskQueue(self.qpath, chunksize=self.chunksize)

def test_serialize(self):
q = self.queue()
@@ -54,7 +54,7 @@ class PickleFifoDiskQueueTest(MarshalFifoDiskQueueTest):
chunksize = 100000

def queue(self):
return PickleFifoDiskQueue(self.qdir, chunksize=self.chunksize)
return PickleFifoDiskQueue(self.qpath, chunksize=self.chunksize)

def test_serialize_item(self):
q = self.queue()
@@ -99,7 +99,7 @@ class ChunkSize4PickleFifoDiskQueueTest(PickleFifoDiskQueueTest):
class MarshalLifoDiskQueueTest(t.LifoDiskQueueTest):

def queue(self):
return MarshalLifoDiskQueue(self.path)
return MarshalLifoDiskQueue(self.qpath)

def test_serialize(self):
q = self.queue()
@@ -120,7 +120,7 @@ def test_nonserializable_object(self):
class PickleLifoDiskQueueTest(MarshalLifoDiskQueueTest):

def queue(self):
return PickleLifoDiskQueue(self.path)
return PickleLifoDiskQueue(self.qpath)

def test_serialize_item(self):
q = self.queue()

2 comments on commit 3365c01

@Zephor5

This comment has been minimized.

Copy link

@Zephor5 Zephor5 replied Sep 17, 2015

Maybe requirements.txt should be fixed with version limitation of queuelib

@dangra

This comment has been minimized.

Copy link
Member Author

@dangra dangra replied Sep 17, 2015

@Zephor5 I think you are right, it is a rare dependency only because of Scrapy extending queuelib's testsuite but it is fair to point this dependency for tests requirements. Fix a3390af

Please sign in to comment.
You can’t perform that action at this time.