Files Pipeline fails on URLs with "?"/get attributes

[mrwonko]

The Files Pipeline does not strip get parameters from the extension and then fails to write the file, at least on Windows/NTFS where "?" is disallowed in filenames.

e.g. files_urls = [ "http://foo.bar/baz.txt?fizz" ] tries to create <hash>.txt?fizz, raising an IOError.

[otobrglez]

@mrwonko && @jschnurr what is the state of this bug? I see that fix was not merged into master. I ran into this issue Today,... Cheers!

[kmike]

Hey @otobrglez,

There is a PR #1548 which has merge+1 vote; we have a policy that two Scrapy commiters must approve a pull request before merging it to master, so currently it waits for another Scrapy commiter to approve and merge it.

[otobrglez]

Hey @kmike! 👋 Is there a way I can help to speed this up?

[kmike]

@otobrglez it will help if you check that PR works for you and add a comment with the results to #1548.