Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files Pipeline fails on URLs with "?"/get attributes #1287

Closed
mrwonko opened this issue Jun 6, 2015 · 4 comments · Fixed by #3954
Closed

Files Pipeline fails on URLs with "?"/get attributes #1287

mrwonko opened this issue Jun 6, 2015 · 4 comments · Fixed by #3954
Labels

Comments

@mrwonko
Copy link

mrwonko commented Jun 6, 2015

The Files Pipeline does not strip get parameters from the extension and then fails to write the file, at least on Windows/NTFS where "?" is disallowed in filenames.

e.g. files_urls = [ "http://foo.bar/baz.txt?fizz" ] tries to create <hash>.txt?fizz, raising an IOError.

@otobrglez
Copy link
Contributor

otobrglez commented Sep 21, 2016

@mrwonko && @jschnurr what is the state of this bug? I see that fix was not merged into master. I ran into this issue Today,... Cheers!

@kmike
Copy link
Member

kmike commented Sep 21, 2016

Hey @otobrglez,

There is a PR #1548 which has merge+1 vote; we have a policy that two Scrapy commiters must approve a pull request before merging it to master, so currently it waits for another Scrapy commiter to approve and merge it.

@otobrglez
Copy link
Contributor

otobrglez commented Sep 21, 2016

Hey @kmike! 👋 Is there a way I can help to speed this up?

@kmike
Copy link
Member

kmike commented Sep 21, 2016

@otobrglez it will help if you check that PR works for you and add a comment with the results to #1548.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants