Skip to content

/ scrapy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOWNLOAD_WARNSIZE is too verbose #1303

Closed
kmike opened this issue Jun 15, 2015 · 5 comments
Closed

DOWNLOAD_WARNSIZE is too verbose #1303

kmike opened this issue Jun 15, 2015 · 5 comments
Labels
help wanted logging

Comments

@kmike
Copy link
Member

@kmike kmike commented Jun 15, 2015

When DOWNLOAD_WARNSIZE is set, there is no Content-Length header and warn limit is reached, Scrapy starts to issue WARNING log messages, a message per a couple of KBs downloaded:

2015-06-15 16:22:23 [scrapy] WARNING: Received (1049869) bytes larger than download warn size (1048576).
2015-06-15 16:22:23 [scrapy] WARNING: Received (1051239) bytes larger than download warn size (1048576).
2015-06-15 16:22:23 [scrapy] WARNING: Received (1052609) bytes larger than download warn size (1048576).
2015-06-15 16:22:23 [scrapy] WARNING: Received (1053979) bytes larger than download warn size (1048576).
2015-06-15 16:22:23 [scrapy] WARNING: Received (1055349) bytes larger than download warn size (1048576).
2015-06-15 16:22:23 [scrapy] WARNING: Received (1056719) bytes larger than download warn size (1048576).
2015-06-15 16:22:23 [scrapy] WARNING: Received (1058089) bytes larger than download warn size (1048576).
2015-06-15 16:22:23 [scrapy] WARNING: Received (1059459) bytes larger than download warn size (1048576).
2015-06-15 16:22:23 [scrapy] WARNING: Received (1060829) bytes larger than download warn size (1048576).
2015-06-15 16:22:23 [scrapy] WARNING: Received (1062199) bytes larger than download warn size (1048576).
...

I think the message should be issued only once.
@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Jun 15, 2015

@kmike once per run or per request ?
@kmike
Copy link
Member Author

@kmike kmike commented Jun 15, 2015

@nramirezuy once per request.

In this case it probably doesn't make sense to show how much more data is received because it will be only slightly larger than a limit.
@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Jun 15, 2015

I agree, maybe change the message and show the request.
@kmike
Copy link
Member Author

@kmike kmike commented Jun 15, 2015

A good idea to show a request.
kmike added a commit to TeamHG-Memex/arachnado that referenced this issue Jun 15, 2015
@kmike
workaround a few Scrapy issues
0a76973 
* scrapy/scrapy#1225
* scrapy/scrapy#1303
* scrapy/scrapy#1308
@kmike kmike added the help wanted label Nov 2, 2015
@aron-bordin aron-bordin mentioned this issue Dec 30, 2015
Merged
@redapple redapple added the logging label Jan 27, 2016
@redapple
Copy link
Contributor

@redapple redapple commented Jan 27, 2016

Fixed in #1654
@redapple redapple closed this Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted logging
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@kmike @redapple @nramirezuy