Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specifying max_active_size for scraper.slot #1410

Closed
vincentlaucy opened this issue Aug 5, 2015 · 3 comments · Fixed by #3551
Closed

allow specifying max_active_size for scraper.slot #1410

vincentlaucy opened this issue Aug 5, 2015 · 3 comments · Fixed by #3551

Comments

@vincentlaucy
Copy link

@vincentlaucy vincentlaucy commented Aug 5, 2015

It's seems to me that such behaviour is undocumented - scraper will be in back out state once there is over 5M requests, as in

self.max_active_size = max_active_size

where the default value is always used.

self.slot = Slot()

I am reaching a deadlock scenario that I have over 5M requests in the slot, then since enqueue request will check for backout, new request can never be completed.

I can submit a PR if it make sense to extract to settings, say SCRAPER_SLOT_MAX_ACTIVE_SIZE

@john156
Copy link

@john156 john156 commented Aug 9, 2015

👍

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Apr 26, 2019

@vincentlaucy Did changing this value fixed your deadlock? Do you remember whether it really a deadlock or just a severe slow down?

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Aug 19, 2019

Closing due to a lack of feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants