Skip to content

/ scrapy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for returning deferreds in middlewares #1471

Closed
ArturGaspar opened this issue Sep 1, 2015 · 1 comment
Closed

Support for returning deferreds in middlewares #1471

ArturGaspar opened this issue Sep 1, 2015 · 1 comment

Comments

@ArturGaspar
Copy link
Contributor

@ArturGaspar ArturGaspar commented Sep 1, 2015

Is there a reason why middlewares cannot return deferreds?
It could be used to fix the limitation mentioned in the documentation of RobotsTxtMiddleware.

The change is simple enough I could make a pull request for it myself, but I thought I would ask first if there is any reason for it to be the way it is.
@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Sep 1, 2015

@ArturGaspar if you can do a PR for that it would be amazing!
@ArturGaspar ArturGaspar mentioned this issue Sep 1, 2015
Merged
@ArturGaspar ArturGaspar changed the title Returning deferreds in middlewares Support for returning deferreds in middlewares Sep 1, 2015
@ArturGaspar ArturGaspar closed this Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@nramirezuy @ArturGaspar
You can’t perform that action at this time.