Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_sent_failed cut the errback chain in MailSender #1611

Closed
aplanas opened this issue Nov 21, 2015 · 2 comments · Fixed by #5880
Closed

_sent_failed cut the errback chain in MailSender #1611

aplanas opened this issue Nov 21, 2015 · 2 comments · Fixed by #5880

Comments

@aplanas
Copy link

aplanas commented Nov 21, 2015

MailSender._sent_failed return None, instead of failure. This cut the errback call chain, making impossible to detect in the code fail in the mails in client code.

@Gallaecio Gallaecio added the bug label Jul 8, 2019
@felipeboffnunes
Copy link
Member

Well this is fair bug, and simple to fix (I guess). How should we go forward with it, though?
We return/raise the failure (not sure which, design-wise) but this is not backwards-compatible. What other things must we do around the fix to deal with the lack of compatibility between versions?
@Gallaecio @wRAR

@Prathm-s
Copy link
Contributor

Hello @aplanas, I am interested in working on this issue, Could you please assign it to me?

wRAR added a commit that referenced this issue Apr 11, 2023
return failure added to _sent_failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants