Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document from_crawler for Scrapy middlewares #1789

Closed
redapple opened this issue Feb 18, 2016 · 1 comment · Fixed by #3626
Closed

Document from_crawler for Scrapy middlewares #1789

redapple opened this issue Feb 18, 2016 · 1 comment · Fixed by #3626

Comments

@redapple
Copy link
Contributor

See motivation #1788

From @kmike

is not clear that Scrapy middlewares have the same features as extensions. Accessing settings is a common use case, I think we should provide examples in middleware docs, even if they are redundant.

@redapple redapple added the docs label Feb 18, 2016
@redapple redapple added this to the v1.1 milestone Feb 18, 2016
@redapple redapple modified the milestones: v1.2, v1.1 May 11, 2016
@redapple redapple modified the milestones: v2.0, v1.2 Jul 22, 2016
@eliasdorneles
Copy link
Member

Just a heads up, @lfmattossch is working on this -- thanks Luiz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants