Scrapy 1.1.0 ImagesPipeline backward incompatibility #1985
Comments
I see. But I must ask how is the philosophy to write Scrapy code? Because I would expect that Also, I would expect that the Plus, I would expect that any attribute intended to be exposed and accessibly should have its own |
@djunzu I think your approach is right, but if a change breaks users code and there is an easy workaround then we usually prefer to add a backwards compatibility shim with deprecation warnings. It doesn't mean users should write code like that (relying on undocumented attributes), but the userbase is large, and we don't want to break user code without a good reason. Also, we should have named attribute |
I agree it's not good to break user code. Especially when there is an easy workaround. I was asking just to know what to expect and what to do as a final user (and eventually as a contributor). |
#1891 is not backward compatible.
Users of Scrapy<1.1
ImagesPipeline
could access upper-case attributes,e.g.
Leading to the following exception in 1.1.0(rc4):
The text was updated successfully, but these errors were encountered: