Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document 'download_latency' key in requests' meta dict #2033

Closed
redapple opened this issue Jun 6, 2016 · 3 comments
Closed

Document 'download_latency' key in requests' meta dict #2033

redapple opened this issue Jun 6, 2016 · 3 comments

Comments

@redapple
Copy link
Contributor

@redapple redapple commented Jun 6, 2016

request.meta['download_latency'] can be useful for analysing a spider or a website, but it's not documented (see #2021).

@kmike
Copy link
Member

@kmike kmike commented Jun 6, 2016

I think it may be undocumented because it is not like other request.meta values. All other documented request.meta values allow to control how Scrapy processes request (i.e. user should write to them), but download_latency is a value user reads read from, not writes to.

@redapple
Copy link
Contributor Author

@redapple redapple commented Jun 6, 2016

@kmike , ok, do you agree it should be mentioned in the docs?

@kmike
Copy link
Member

@kmike kmike commented Jun 6, 2016

Yes, I think we should mention it, but I'm not sure I like that meta is used for so many things. I still think we should fix at least #1138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.