Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept single values for "to" and "cc" arguments when sending mails #2272

Closed
redapple opened this issue Sep 20, 2016 · 8 comments
Closed

Accept single values for "to" and "cc" arguments when sending mails #2272

redapple opened this issue Sep 20, 2016 · 8 comments
Milestone

Comments

@redapple
Copy link
Contributor

@redapple redapple commented Sep 20, 2016

Follow up to #2271 (comment)

What about checking for strings and raising an error?
Passing a string is an easy mistake to make.
Or maybe we can support passing a single string.

@kirankoduru
Copy link
Contributor

@kirankoduru kirankoduru commented Oct 4, 2016

Hey @redapple, I would like to work on this. Can you tell me if checking for isinstance of basestring a good idea so I can cast the to argument into a list ?

@redapple
Copy link
Contributor Author

@redapple redapple commented Oct 4, 2016

hi @kirankoduru , thanks for stepping in!
keep in mind that basestring is not in Python 3.
You may want to look at something like arg_to_iter which does tests for single valued arguments in a Python2/Python3 compatible way.

@kirankoduru
Copy link
Contributor

@kirankoduru kirankoduru commented Oct 4, 2016

@redapple that's exactly what I was looking for! I will create a PR soon. Thanks :)

@lfmattossch
Copy link
Contributor

@lfmattossch lfmattossch commented Oct 18, 2016

Hey @kirankoduru are you still working on this?

@kirankoduru
Copy link
Contributor

@kirankoduru kirankoduru commented Oct 18, 2016

hey @lfmattossch I was working last weekend. Some reasons my tests weren't passing. I was under the impression that tox was the command to run them. Is there any other way to run them? Also if you want to work on it please go ahead and start.

@moisesguimaraes
Copy link
Contributor

@moisesguimaraes moisesguimaraes commented Oct 18, 2016

hi @kirankoduru, I'm with @lfmattossch. I'm already running the unit tests on a fix. Thanks for updating us.

@kirankoduru
Copy link
Contributor

@kirankoduru kirankoduru commented Oct 18, 2016

@moisesguimaraes @lfmattossch great guys. Has the fix been pushed yet? I wonder how it was merged without passing tests.

@moisesguimaraes
Copy link
Contributor

@moisesguimaraes moisesguimaraes commented Oct 18, 2016

not yet. I'm testing it locally.

@redapple redapple added the in progress label Nov 4, 2016
@redapple redapple added this to the v1.3 milestone Nov 16, 2016
@kmike kmike closed this in #2331 Dec 7, 2016
@redapple redapple removed the in progress label Dec 7, 2016
kmike added a commit that referenced this issue Dec 7, 2016
[MRG+1] Fixes issue #2272 using arg_to_iter() to wrap single values and list() to…
darshanime added a commit to darshanime/scrapy that referenced this issue Dec 8, 2016
* master:
  removes note from docs.
  fixes params types in docs.
  fixes docs
  Wipe scrapy.xlib.tx
  Deprecate scrapy.xlib.tx
  Import xlib.tx code from twisted proper
  Remove obsolete xlib code for Twisted 13.1.0
  Bump Twisted dependency to 13.1.0 (released June 2013)
  Strip xlib.tx code of Twisted 10
  TST Include nested a nested spider in spider loader test.
  DOC State explicitly that spiders are loaded recursively.
  Remove docs for deprecated ChunkedTransfer middleware
  Update warning wording
  Add deprecation warning for ChunkedTransfer middleware
  Remove ChunkedTransferMiddleware from default settings
  fixes import for py35 env.
  (fixes scrapy#2272) using arg_to_iter() to wrap single values and list() to avoid consuming from generators.
darshanime added a commit to darshanime/scrapy that referenced this issue Dec 8, 2016
* master:
  removes note from docs.
  fixes params types in docs.
  fixes docs
  Wipe scrapy.xlib.tx
  Deprecate scrapy.xlib.tx
  Import xlib.tx code from twisted proper
  Remove obsolete xlib code for Twisted 13.1.0
  Bump Twisted dependency to 13.1.0 (released June 2013)
  Strip xlib.tx code of Twisted 10
  TST Include nested a nested spider in spider loader test.
  DOC State explicitly that spiders are loaded recursively.
  Remove docs for deprecated ChunkedTransfer middleware
  Update warning wording
  Add deprecation warning for ChunkedTransfer middleware
  Remove ChunkedTransferMiddleware from default settings
  fixes import for py35 env.
  (fixes scrapy#2272) using arg_to_iter() to wrap single values and list() to avoid consuming from generators.
darshanime added a commit to darshanime/scrapy that referenced this issue Dec 8, 2016
* master:
  removes note from docs.
  fixes params types in docs.
  fixes docs
  Wipe scrapy.xlib.tx
  Deprecate scrapy.xlib.tx
  Import xlib.tx code from twisted proper
  Remove obsolete xlib code for Twisted 13.1.0
  Bump Twisted dependency to 13.1.0 (released June 2013)
  Strip xlib.tx code of Twisted 10
  TST Include nested a nested spider in spider loader test.
  DOC State explicitly that spiders are loaded recursively.
  Remove docs for deprecated ChunkedTransfer middleware
  Update warning wording
  Add deprecation warning for ChunkedTransfer middleware
  Remove ChunkedTransferMiddleware from default settings
  fixes import for py35 env.
  (fixes scrapy#2272) using arg_to_iter() to wrap single values and list() to avoid consuming from generators.
darshanime added a commit to darshanime/scrapy that referenced this issue Dec 10, 2016
* master:
  removes note from docs.
  fixes params types in docs.
  fixes docs
  Wipe scrapy.xlib.tx
  Deprecate scrapy.xlib.tx
  Import xlib.tx code from twisted proper
  Remove obsolete xlib code for Twisted 13.1.0
  Bump Twisted dependency to 13.1.0 (released June 2013)
  Strip xlib.tx code of Twisted 10
  TST Include nested a nested spider in spider loader test.
  DOC State explicitly that spiders are loaded recursively.
  Remove docs for deprecated ChunkedTransfer middleware
  Update warning wording
  Add deprecation warning for ChunkedTransfer middleware
  Remove ChunkedTransferMiddleware from default settings
  fixes import for py35 env.
  (fixes scrapy#2272) using arg_to_iter() to wrap single values and list() to avoid consuming from generators.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants