Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note that CrawlerProcess.crawl() needs a crawler or spider class, not a spider instance #2283

Closed
redapple opened this issue Sep 23, 2016 · 0 comments
Labels

Comments

@redapple
Copy link
Contributor

@redapple redapple commented Sep 23, 2016

Even if it's in the docs,

crawler_or_spidercls (Crawler instance, Spider subclass or string) – already created crawler, or a spider class or spider’s name inside the project to create it

users still miss sometimes that .crawl() expects a Spider class (or a crawler) but not a Spider instance.

e.g. http://stackoverflow.com/q/39639568

I overlooked the fact that the class itself has to be passed as an argument, and not an instance of that class.
This is quite subtle on the eye but makes all the difference

This ticket is to make it a bit more prominent.

@redapple redapple added the docs label Sep 23, 2016
@redapple redapple changed the title Add note that CrawlerProcess.crawl() needs a crawler or spider class, not an instance Add note that CrawlerProcess.crawl() needs a crawler or spider class, not a spider instance Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant