Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority value, Higher or Lower? #2289

Closed
pykler opened this issue Sep 27, 2016 · 2 comments
Closed

Priority value, Higher or Lower? #2289

pykler opened this issue Sep 27, 2016 · 2 comments
Labels

Comments

@pykler
Copy link

@pykler pykler commented Sep 27, 2016

There is a contradiction in the documentation.

http://doc.scrapy.org/en/latest/topics/settings.html?highlight=priority#depth-priority

vs

http://doc.scrapy.org/en/latest/topics/request-response.html?highlight=priority#scrapy.http.Request

The first says a positive number will mean lower priority. The latter says a higher number means a higher priority. So what is it?

@eLRuLL
Copy link
Member

@eLRuLL eLRuLL commented Sep 27, 2016

not sure if this needs to be fixed or maybe add a better explanation, as they are different things.

DEPTH_PRIORITY is a settings parameter to be used with CrawlSpider's rules (this isn't specified on the documentation). The number specified here won't be going directly into the Request's priority attribute. The Documentation explains how to use this parameter.

priority is a Request attribute to set specific priority in the request's stack.

@redapple
Copy link
Contributor

@redapple redapple commented Sep 27, 2016

@eLRuLL , DEPTH_PRIORITY is a setting read by DepthMiddleware, not specifically for CrawlSpider.
In DepthMiddleware, DEPTH_PRIORITY affects Requests priority but with a minus sign, so the documentation is correct. But I admit it can be confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants