Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DepthMiddleware docs should mention request.meta['depth'] #2374

Closed
kmike opened this issue Nov 2, 2016 · 11 comments · Fixed by #2963
Closed

DepthMiddleware docs should mention request.meta['depth'] #2374

kmike opened this issue Nov 2, 2016 · 11 comments · Fixed by #2963
Labels
docs good first issue

Comments

@kmike
Copy link
Member

kmike commented Nov 2, 2016

request.meta['depth'] is set by DepthMiddleware, but its docs don't mention that. I think it'd be nice to add this information.
@arush0311
Copy link

Can i take this?

@kmike
Copy link
Member Author

kmike commented Dec 16, 2016

@arush0311 yes, help is appreciated!

arush0311 added a commit to arush0311/scrapy that referenced this issue Dec 19, 2016
@arush0311
docs/spider-middleware: DepthMiddleware sets request.meta['depth']
e97ecec 
Fixes scrapy#2374
arush0311 added a commit to arush0311/scrapy that referenced this issue Dec 19, 2016
@arush0311
docs/spider-middleware: DepthMiddleware sets request.meta['depth']
093b889 
Fixes scrapy#2374
@arush0311 arush0311 mentioned this issue Dec 19, 2016
Closed
arush0311 added a commit to arush0311/scrapy that referenced this issue Dec 20, 2016
@arush0311
docs/spider-middleware: DepthMiddleware sets request.meta['depth']
57b69fe 
Fixes scrapy#2374
arush0311 added a commit to arush0311/scrapy that referenced this issue Dec 20, 2016
@arush0311
docs/spider-middleware: DepthMiddleware sets request.meta['depth']
ff0057e 
Fixes scrapy#2374
@arush0311
Copy link

sure go ahead.

@amrx101
Copy link

amrx101 commented Aug 9, 2017

Is this closed or up for grabs?

@redapple
Copy link
Contributor

redapple commented Aug 9, 2017

@amrx101 , I believe it's still up for grabs. Have a look at the previous #2455

@krishamehta
Copy link

Is it still up? Would like to help

@djunzu
Copy link
Contributor

djunzu commented Oct 5, 2017

@krishamehta , still up, go for it! :)

@krishamehta
Copy link

Will start working on this!

@pranjalverma
Copy link

pranjalverma commented Oct 16, 2017 •
edited

I would like to take this if this is still up. This is my first ever open source contribution, can anyone guide me? How exactly do I edit the docs? I really don't wanna mess this up. Much appreciated.

@djunzu djunzu mentioned this issue Oct 16, 2017
Merged
@ghost
Copy link

ghost commented Oct 21, 2017

Still open? I'd like to take a crack at this

@krishamehta
Copy link

I have started working on this
But since im new at open source , its taking a bit longer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add note about request.meta['depth'] in DepthMiddleware djunzu/scrapy
7 participants
@kmike @redapple @djunzu @amrx101 @arush0311 @krishamehta @pranjalverma