Skip to content

/ scrapy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to set RETRY_TIMES per-request #2642

Closed
kmike opened this issue Mar 10, 2017 · 4 comments
Closed

allow to set RETRY_TIMES per-request #2642

kmike opened this issue Mar 10, 2017 · 4 comments
Labels
good first issue help wanted
Milestone
v1.4

Comments

@kmike
Copy link
Member

@kmike kmike commented Mar 10, 2017

I think it'd be nice to allow set RETRY_TIMES per-request using a request.meta key ("max_retry_times"?) - some requests could be more important than others.
@atultherajput
Copy link

@atultherajput atultherajput commented Mar 11, 2017

I am a newbie to open source. I know Python programming language. Please guide me to fix this issue.
harshasrinivas added a commit to harshasrinivas/scrapy that referenced this issue Mar 11, 2017
@harshasrinivas
Add feature to set RETRY_TIMES per request (scrapy#2642)
810658b
@harshasrinivas harshasrinivas mentioned this issue Mar 11, 2017
Merged
@saurabhgoyaliitr
Copy link

@saurabhgoyaliitr saurabhgoyaliitr commented Mar 17, 2017

is this still open to try?
@redapple
Copy link
Contributor

@redapple redapple commented Mar 17, 2017

hi @saurabhgoyaliitr , do you mean you want to work on fixing it?
#2643 by @harshasrinivas has already done most of the work I believe.
kmike added a commit that referenced this issue May 17, 2017
@kmike
Merge pull request #2643 from harshasrinivas/set-retry-times-per-request
Loading status checks…
532400f 
[MRG+1] Add feature to set RETRY_TIMES per request (#2642)
@redapple
Copy link
Contributor

@redapple redapple commented May 17, 2017

Fixed in #2643
@redapple redapple closed this May 17, 2017
@kmike kmike added this to the v1.4 milestone May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
v1.4
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@kmike @redapple @saurabhgoyaliitr @atultherajput
You can’t perform that action at this time.