Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrapy docs: 'make htmlview' does not open the webbrowser #2661

Closed
harshasrinivas opened this issue Mar 17, 2017 · 3 comments
Closed

Scrapy docs: 'make htmlview' does not open the webbrowser #2661

harshasrinivas opened this issue Mar 17, 2017 · 3 comments

Comments

@harshasrinivas
Copy link
Contributor

@harshasrinivas harshasrinivas commented Mar 17, 2017

After compiling the scrapy documentation, make htmlview does not open the web browser.

>>> webbrowser.open('build/html/index.html') # does not work
>>> webbrowser.open('file:///path/to/the/index.html') # works

It works when I give the full path to the build/html/index.html file.
I have tested this using Python 2.7 and 3.6 on MacOS.

I believe this is an issue specific to MacOS. A minor change to the webbrowser.open() command in the Makefile should fix this bug. Shall I go ahead and fix this?

@harshasrinivas
Copy link
Contributor Author

@harshasrinivas harshasrinivas commented Mar 24, 2017

Any update on this?

@redapple
Copy link
Contributor

@redapple redapple commented Mar 24, 2017

hi @harshasrinivas , I have no way to test this. I'm on Xubuntu, and make htmlview works for me.
maybe @kmike, @lopuhin or @stummjr can check (I think they have Macs)

@stummjr
Copy link
Member

@stummjr stummjr commented Mar 24, 2017

hey @redapple @harshasrinivas. Just tested it on Macos with Python 3.5 and confirmed that make htmlview doesn't open a browser window if you don't provide a URL scheme.

harshasrinivas added a commit to harshasrinivas/scrapy that referenced this issue Mar 24, 2017
@kmike kmike closed this in #2682 Mar 24, 2017
kmike added a commit that referenced this issue Mar 24, 2017
…wser

[MRG+1] Update Makefile to open webbrowser in MacOS (#2661)
khchine5 added a commit to khchine5/scrapy that referenced this issue Mar 28, 2017
Update Makefile to open webbrowser in MacOS (scrapy#2661)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.